search

SirFancyBacon / baconcraft

Baconcraft repositoy; basically just for issues, feature requests, bugs, that sort of thing.
0 stars 0 forks source link

[BUG] - Villager weapons & armor is "normal" gear #7

Open metruzanca opened 2 years ago

metruzanca commented 2 years ago

Describe the bug Villager weapons & armor is "normal" gear

To Reproduce Buy from villager

Expected behavior Expected to be custom diamond armor/tools

image

SirFancyBacon commented 2 years ago

This one might be a toughie.. I am not sure i can edit Villager trades without also hard coding them

SirFancyBacon commented 2 years ago

meaning they would never change and always be the same

SirFancyBacon commented 2 years ago

Digging into it.. Looks like all i can do is hardcode the trades with a boat load of custom villagers; then when one becomes a profession it will randomly pick one of the trade templates and set it

SirFancyBacon commented 2 years ago

However, if you bring me normal equipment i will exchange it for a matching custom item; even if i need to "forge" it myself.

metruzanca commented 2 years ago

It might be easier to just have a something that replaces normal equipment for custom equipment.

Hardcoding villagers is going to be living hell since you're going to also have to hardcode all the price variations depending on player village reputation score.

SirFancyBacon commented 2 years ago

So, the easiest solution i thought of, is all of the custom items have a recipe where in if you place a vanilla item in a crafting table it will become a custom one.

The downside to this would be any enchantment would be lost on the item..

metruzanca commented 2 years ago

The downside to this would be any enchantment would be lost on the item..

Well thats really bad considering theres no advantage to using custom tools that aren't swords :/ (upgrading)