search

SirHitech / MapleXPBar

BSD 2-Clause "Simplified" License
0 stars 2 forks source link

Health/Prayer bars #1

Closed OrionAF closed 2 years ago

OrionAF commented 2 years ago

Could you add support for health bar and Prayer bar? And maybe have multiple so you can have XP, health and Prayer?

SirHitech commented 2 years ago

Adding the option to display health or prayer sounds good, however my worry with having multiple at once is cluttering the area where split private chat is - which is the reason why the bar is pretty thin to begin with. I'll play around with a few ideas, and I'll take any suggestions for displaying them.

OrionAF commented 2 years ago

Is it possible to move the split private chat like you can move the minimap? If you can, you could have a toggle-able option to move split private chat when using 2-3 bars.

SirHitech commented 2 years ago

Moving split chat would be one solution, however I'm not aware of how to do that. I made this mockup of health, prayer, and xp bars all together, and it actually came out much nicer than I had expected. What do you think? MapleXPBar with health and prayer

OrionAF commented 2 years ago

That looks pretty good. Would it be possible to have a toggleable option to have them stackable? I personally don't use split chat so for those of us who don't use it, it could work out.

SirHitech commented 2 years ago

Yeah, I don't see why not! Let's go with that then.

OrionAF commented 2 years ago

Awesome 😀

SirHitech commented 2 years ago

Alrighty, we've got a toggle to add the health and prayer bars, colors for the new bars, and I threw in the ability to color the notches for each bar since the default prayer color doesn't work well with the light notches I was using before. MapleXPBar with health and prayer - stacked

OrionAF commented 2 years ago

Ohh that's awesome 😀

SirHitech commented 2 years ago

Great to hear! I'm gonna mess around and make sure nothing is broken with it, and if it seems stable I'll open the merge request for the main runelite repo.

OrionAF commented 2 years ago

Looking forward to it 😀

SirHitech commented 2 years ago

Code is live, let me know how it is.

OrionAF commented 2 years ago

That looks awesome, thank you 😀

OrionAF commented 2 years ago

hmmm, quick question. How would the HP bar act if you drink a brew or eat a over the HP cap food?

SirHitech commented 2 years ago

It handles boosted health or prayer as if it's your max, so the bar shouldn't bug out if you have it boosted. I've only tested it on a +2 prayer altar since I only have membership on a GIM, and don't have brews or anything easy to test the HP with. So basically any boosted hp/pray will just show as full until you drop below your true max hp/pray.

OrionAF commented 2 years ago

aah okay, awesome :D