SirLagz / zerotier-console

CLI utility for managing ZeroTier self-hosted controllers and a frontend for zerotier-cli
GNU Affero General Public License v3.0
18 stars 2 forks source link

Big improvements to the client list #10

Closed majik-sheff closed 1 year ago

majik-sheff commented 1 year ago

I had to roll back your preliminary wrapper code to do testing but hopefully it won't prove too difficult to integrate back into what you're doing.

I separated out the IP verification into a function and added some more features/bug fixes. Then integrated it into one other spot were IPs are entered.

I also reworked the handling of parsing the client list. It now runs all parsing operations in tandem and just re-collates the results after they arrive. Loading time for a list of any length is now a couple of seconds.

majik-sheff commented 1 year ago

Hopefully the code rollback didn't create too many headaches for you. I wanted to try out my new approach and needed a known starting point.

On Thu, Aug 3, 2023 at 9:52 AM Lawrence @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/SirLagz/zerotier-console/pull/10#pullrequestreview-1561287335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3DMON44TWL3K5YI3LQIX3XTO3KZANCNFSM6AAAAAA24MOY54 . You are receiving this because you authored the thread.Message ID: @.***>

SirLagz commented 1 year ago

Hopefully the code rollback didn't create too many headaches for you. I wanted to try out my new approach and needed a known starting point. On Thu, Aug 3, 2023 at 9:52 AM Lawrence @.> wrote: @*.*** approved this pull request. — Reply to this email directly, view it on GitHub <#10 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3DMON44TWL3K5YI3LQIX3XTO3KZANCNFSM6AAAAAA24MOY54 . You are receiving this because you authored the thread.Message ID: @.>

All good mate, just a few minutes with the conflict resolver and it was all sorted :)