SirMashedPotato / ESCP-Maormer

Maormer race for RimWorld, part of the ESCP
0 stars 1 forks source link

Industrial_Royalty_EmpirePatches references pawnkind `ESCP_MaormerVillager` but PawnKindDef is missing (probably `ESCP_MaormerKind`) #3

Open slippycheeze opened 2 years ago

slippycheeze commented 2 years ago

log excerpt:

Could not resolve cross-reference: No RimWorld.FactionDef named ESCP_MaormerOutlanderCivil found to give to RimWorld.QuestGen.QuestNode_GetRandomPawnKindForFaction+Choice RimWorld.QuestGen.QuestNode_GetRandomPawnKindForFaction+Choice 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Could not resolve cross-reference to Verse.PawnKindDef named ESCP_MaormerVillager (wanter=pawnKinds) 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

I believe this is an error in the industrial factions patch, which references a pawnkind that isn't defined. I strongly suspect it should refer to ESCP_MaormerKind, which is the PawnKindDef with the outlander backstory category, but I'm only 90 percent sure... hence a bug report, not a patch.

https://github.com/SirMashedPotato/ESCP-Maormer/blob/ed9c7eaf06a0a352f41fc3a57b5089e6601151a3/Mods/IndustrialFactions/Patches/Industrial_Royalty_EmpirePatches.xml#L57-L60

https://github.com/SirMashedPotato/ESCP-Maormer/blob/ed9c7eaf06a0a352f41fc3a57b5089e6601151a3/1.3/Defs/PawnKindDefs_Humanlikes/PawnKind_Maormer.xml#L5

note: I'm not sure this actually has any negative in-game effect, but since I'm checking my logs for errors I figured to report it.

SirMashedPotato commented 2 years ago

Fixed in version 1.0.10.