search

SirSquidly / Oceanic-Expanse

A 1.12.2 Minecraft Mod which adds various pieces of ocean-based content.
9 stars 1 forks source link

OE kelp/seagrass? + Fluidlogged API quirk / DynamicSurroundings "splash" incompatibility #10

Closed Sethgno closed 1 week ago

Sethgno commented 1 year ago

when oe:kelp grows (naturally/bonemeal) the topmost kelp block will create a repeating "dynamicSurroundings splash" effect while fluidLogging is installed and DS splash is enabled. this effect will persist until the kelp is broken. (DS splash effect occurs whenever there is "flowing water")

tested with other modded "underwater growth" blocks. oe kelp is only one that triggers it, and also the tall seagrass i believe. (EDIT_2: just realized that the other mod i tested this with was also by the author of FL API. so assumedly theres a chance that most other mods would also have this issue due to not being "in line" with FL's code, in which case it would be a "FL API + DS incompat issue" on FL/DS's side, or a "X Mod + FL issue" on every other mod's side. until then OE is the only instance i've find )

assuming that whatever causes it triggers regardless of DS being installed, it just also makes it more noticeable lol

https://www.curseforge.com/minecraft/mc-mods/dynamic-surroundings EDIT: tested with VERY old version of DS! will return with more info tested with newest version of DS (3.6.1.0)

2023-04-23_23 46 16 2023-04-23_23 46 19

vico93 commented 11 months ago

I had the same issue here. Seems like the kelp leaves behind air that the other water source blocks try to fill, creating the sounds.

SirSquidly commented 11 months ago

This is an odd one, I've been looking into it to see why exactly it is. It might be a weird interaction between Fluidlogged and Dynamic Surroundings, as Dynamic Surroundings is checking for Material.Water, and Fluidlogged intentionally doesnn't use Material.Water.

SirSquidly commented 11 months ago

To be more specific, I think this issue is popping up as my mod, Oceanic Expanse, has separate blocks for Short and Tall Seagrass, along with separate blocks for Top and Mid Kelp. The Seagrass thing is fixable, although the kelp was broken up to try and lower the amount of random block updates that would be called.

I might change that behavior in the future, combining the technical blocks, although that would have to be a straight up 2.0.0 version as it wouldn't work seamlessly in a pre-made world.

SirSquidly commented 1 week ago

Fixed in the 1.1.0 update.

SirSquidly commented 1 week ago

Testing this myself, I've found the issue persists. How annoying.

SirSquidly commented 1 week ago

Tested, and CONFIRMED to finally be fixed 1.1.1.

If this re-appears for new plants, please make a new issue.