SirSquidly / Oceanic-Expanse

A 1.12.2 Minecraft Mod which adds various pieces of ocean-based content.
9 stars 2 forks source link

[Suggestion] Improve aquatic biomes generation #79

Open XvaleX10 opened 2 months ago

XvaleX10 commented 2 months ago

Structures from other mods spawn on top of glaciers 2024-05-19_19 18 45 Biomes spawn without logic, causing biomes like the frozen ocean near deserts or near warm oceans Could it be solved by implementing real biomes like the Kelp Forest of Biomes O Plenty? However the mod is very good 2024-05-19_19 26 03 2024-05-19_19 27 07

SirSquidly commented 2 months ago

I'm unsure why other mods spawn structures atop literal ice, that seems like their issue.

As for biome-gen, Oceanic Expanse doesn't exactly have real biomes, as in 1.12.2, there is no vanilla support for custom Ocean Biomes. This means I don't really have a way to properly check the temperature map, as Oceanic Expanse's fake biomes are literally random.

I might make a later version compatible with Subaquatic, as that mod has real ocean biomes, but it would also lead to a ridiculous amount of features being cut or reworked.

darkheadmaster132 commented 1 month ago

the structure gen in 1.12.2 is very outdated and tricky to work with, especially modded world gen, based on that picture the structure would be spawned on the ice regardless, because other mod creator probably did not specify on what biomes the structure can generate in and on what block the structure has to be generated on, there is nothing they can do to fix something other mod dev did not add