SirSquidly / Oceanic-Expanse

A 1.12.2 Minecraft Mod which adds various pieces of ocean-based content.
9 stars 1 forks source link

Submission of Simplified Chinese Language File #81

Open SaltOvOFish opened 1 month ago

SaltOvOFish commented 1 month ago

Hello, I’ve noticed that version 1.1.2 of the MOD has added several new language files, including “Shakespearean English,” “Pirate Speak,” and “LOLCAT.” Are you interested in adding support for more languages? I would like to submit a Chinese language file to you (Includes all content from version 1.1.2). This language file has already been submitted to “I18nUpdateMod” (a well-known MOD that provides Chinese translations for other MODs) (CurseForgeModrinthGitHub) and has passed their review process and been successfully merged into the project, so there’s no need to worry about the accuracy of the translation. Of course, if you have any suggestions for modifications, please feel free to bring them up, and I will make changes according to your feedback. Of course, if you’re not interested in adding more languages at this time, then please disregard my message. Sorry for the disturbance. zh_cn.txt

SirSquidly commented 1 month ago

Wait, I let that slip into the 1.1.2 version‽ Yikes, those translations weren't fully completed!

Also I would love to directly add more translations to the mod! I already planned on having feelers out for any translators, so this is a pleasant surprise!

Scanning the I18nUpdateMod GitHub, I see you were the one to upload said translations, and I am incredibly thankful for that! I definitely would like to incorporate the translations, and would like to give any assistance possible to help you!

SaltOvOFish commented 1 month ago

I am very pleased that you can say this. The above text already includes translations of all the content in en_us.lang, but there are indeed some minor issues that require your assistance. Firstly, the annotation text for ‘Conduit Charm,’ ‘Conduit Power when outside of a Conduit’s Range,’ is not included in en_us.lang, so this sentence has not been translated yet. If it can be added later, the corresponding Chinese translation can also be included. Additionally, there is an issue with the ‘Bucket of Mob.’ The standard Chinese translation in Vanilla is ‘生物(Mob)桶 (Bucket)’, which reverses the order compared to English. For example, ‘Bucket of Cod’ is translated as ‘鳕鱼(Cod)桶(Bucket)’. However, because the original text given by Oceanic Expanse is 'item.oe.spawn_bucket.name=Bucket of ', this part of the translation cannot differ from the standard Chinese translation in Vanilla for the time being. Could you add a placeholder and change it to ‘Bucket of %s’ (I’m not sure if this change is correct), so that this part can be modified to ‘%s Bucket’ to be consistent with the standard Chinese translation in Vanilla. I am very happy that you are willing to incorporate the Chinese translation into the MOD. If there are new contents added to the MOD in the future, I will also keep updating this part of the translation. Thank you very much for your help.

SirSquidly commented 1 month ago

Both changes (Conduit Charm description moved to Translations, and Bucket name using a format specifier) have been made to the GitHub.

I will push an update for the mod most likely tomorrow, as I am pressed on time today.

Please let me know any other changes or tweaks that would be helpful, I will be happy to implement them.

SaltOvOFish commented 1 month ago

image Can the comment text in the ‘MOD Config’ section be included in the en_us.lang file? If we add this portion of text, then all the content that appears in the mod should be translatable. This would also assist other translators. Then there are no other issues. After the new version of the mod is released, I will promptly update the Chinese translation text and submit it to you.

SirSquidly commented 1 month ago

In testing, I have found that the in-game Config Comment Text can be overridden by adding new lines to the .lang file, where they use the the config option's name with .tooltip added to the end. For example, adding oe.config.worldGen.enableCoquinaOutcrops.tooltip to the .lang will allow overriding the in-game comment text for that option.

So, as far as I can tell, the in-game config comment text can already be altered.

Note that this only will alter the in-game displayed text, the Forge's config text file does not support Lang Keys.

SaltOvOFish commented 1 month ago

Yes, this is indeed possible. I have spent some time and have completed all the translations for this part, with each line of comments placed under the corresponding option. Additionally, I have optimized the translations in some areas. Then, based on ‘description.oe.charm.name=Gives Conduit Power when outside of a Conduit’s Range.’ and ‘item.oe.spawn_bucket.name=Bucket of %s’, I translated the corresponding content, hoping they are effective. This is the TXT file after the modifications. Overall, there should be no issues now. Thank you very much for your help. zh_cn.txt