search

SirVer / ultisnips

UltiSnips - The ultimate snippet solution for Vim. Send pull requests to SirVer/ultisnips!
GNU General Public License v3.0
7.56k stars 691 forks source link

Check Vim version through call to Vim's has() function #1516

Closed mymedia2 closed 1 year ago

mymedia2 commented 1 year ago

It looks Vim 9.0 changed format output of --version and no longer prints applied extra patches on a separate line but joins the patch numbers with comma. As @jamessan rightly noted, the has_version method should check whether patchlevel is in set of listed patches.

And it is worth mentioning that the exact format is not documented and may change in future.

Fixes: #1514

mymedia2 commented 1 year ago

@jamessan Thank you for the review and the explanation. I rewrote the patch to call of the Vim's original has() function and the has_version() method in Python code became shorter.

SirVer commented 1 year ago

Wonderful! Thanks for the contribution.

SirVer commented 1 year ago

Also thanks to @jamessan for reviewing. What an exemplary piece of open source interaction this contribution was - only I stick out like a sore thumb coming super late to press the merge button. Thanks you both!