search

SiriusLab / ModelDebugging

Runtime and tools to bring execution and simulation in your domain specific tooling built with Sirius and/or Eclipse Modeling Framework.
Eclipse Public License 1.0
6 stars 10 forks source link

[Debug-Layer generation] Fix compilation errors of generated service class #17

Closed tortmayr closed 7 years ago

tortmayr commented 7 years ago

Using UI support (wizard or context command) for adding a debug-layer to an odesign-file results in compliation errors in the corresponding *DebugServices class.

The template used for the class generation is deprecated and doesn't implement all abstract methods of AbstractGemocDebuggerServices.

This fix updates the template and adds the necessary manifest changes.

(the xMOF-GEMOC integration is reusing this functionality and with this fix a couple of isses will get resolved)

ebousse commented 7 years ago

I can reproduce the bug, indeed this part had not been updated in a while, and using the UI the generated DebugServices class does not compile.

Everything looks good to me, let's merge :)

Thanks for the PR! Don't hesitate to suggest other changes if you see anything else wrong in the GEMOC framework.

dvojtise commented 7 years ago

This effectively provides a better code that works out of the box for sequential use cases, however it add a default implementation for the getModelIdentifier() method that is specific to the sequential engine. This will not work with the concurrent engine, coordination or xmof engines. (this is related to bug 25 https://github.com/gemoc/gemoc-studio/issues/25 )

Ideally the wizard should know/ask which engine it targets. As a quick fix I'll improve the patch by adding a comment/documentation

ebousse commented 7 years ago

Fair point, I missed that aspect. Sorry about that :). Yes you are right the wizard should be made smarter to manage all the cases well.

combemale commented 7 years ago

@Erwan: can you manage this point?

thanks, benoit

Le 24 avr. 2017 à 10:37, Erwan Bousse notifications@github.com a écrit :

Fair point, I missed that aspect. Sorry about that :). Yes you are right the wizard should be made smarter to manage all the cases well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SiriusLab/ModelDebugging/pull/17#issuecomment-296688653, or mute the thread https://github.com/notifications/unsubscribe-auth/ADtBUH4ClJEqHdahoPt-ioLaYoMtJH78ks5rzLOfgaJpZM4NCTMX.

ebousse commented 7 years ago

I need a better understanding of all this. Continuing the discussion of the root problem in https://github.com/gemoc/gemoc-studio/issues/25.