search

SiriusLab / ModelDebugging

Runtime and tools to bring execution and simulation in your domain specific tooling built with Sirius and/or Eclipse Modeling Framework.
Eclipse Public License 1.0
6 stars 10 forks source link

Remove confusion AbstractDSLLaunchConfigurationDelegateUI classes #31

Open ebousse opened 7 years ago

ebousse commented 7 years ago

To better distinguish the classes

org.eclipse.gemoc.dsl.debug.ide.sirius.ui.launch.AbstractDSLLaunchConfigurationDelegateUI

and

org.eclipse.gemoc.dsl.debug.ide.ui.launch.AbstractDSLLaunchConfigurationDelegateUI

this commit renames the former to AbstractDSLLaunchConfigurationDelegateUI2

For some reason, this caused me really strange compilation errors in Eclipse, while probably tycho is not bothered.

ylussaud commented 7 years ago

Please not AbstractDSLLaunchConfigurationDelegateUI2... let say org.eclipse.gemoc.dsl.debug.ide.sirius.ui.launch.AbstractDSLLaunchConfigurationDelegateSiriusUI

If it's ok with you ? I know it's a bit long but meaningful.

ebousse commented 7 years ago

That's perfectly OK for me! I was not very inspired for the new name :)

I'll refactor the PR later today then.

ylussaud commented 7 years ago

thanks a lot

dvojtise commented 7 years ago

with the transfer of the code to the Eclipse foundation (see gemoc@eclipse), this repository is now deprecated and replaced by https://github.com/eclipse/gemoc-studio-modeldebugging/

Since only the master branch was transfered, this pull request was not taken into account.

Please consider contributing/adapting this pull request to the new official repository https://github.com/eclipse/gemoc-studio-modeldebugging/