search

Sirspam / Nya

A BeatSaber mod for displaying nya-tastic images from various web APIs
MIT License
26 stars 12 forks source link

Bugfix/fix exceptions #2

Closed ErisApps closed 3 years ago

ErisApps commented 3 years ago

A user reported an issue (https://github.com/ErisApps/SongChartVisualizer/issues/7) regarding an incompatibility between one of my repos and Nya. After further investigation, I was able to pinpoint the cause being Nya throwing exceptions in the Dispose method which caused a partial breakdown of the Zenject kernel. This PR, as the title stated already, fixes those few exceptions.

Other than that, the linked issue mentioned another exception during setup of the BSML screen, which is basically a race condition. That one is now also fixed.

Sirspam commented 3 years ago

Ah, would've never thought Nya would somehow break Song Chart Visualizer Thanks a lot for the PR, sorry you had to go out of your way to fix it.

ErisApps commented 3 years ago

No worries, glad I was able to help out.