Sitata / titanium-google-analytics

Google analytics for Appcelerator Titanium
MIT License
92 stars 47 forks source link

Modifies field validation macro to allow nil currency parameter #1

Closed ndizazzo closed 9 years ago

ndizazzo commented 9 years ago

I noticed while looking at the source for tracker.trackTransactionItem, that the "currency" parameter is not using the same macro as in tracker.trackTransaction to ensure the field's value. I changed the macro it was using to make it consistent with the documentation in the readme file and the tracker.trackTransaction call.

astjohn commented 9 years ago

That's awesome. Thanks for this! I look forward to hearing if the currency transaction stuff works for you. I know it takes a while to register with google...

ndizazzo commented 9 years ago

It works properly for us now - thanks. I'm also more comfortable that it's using a newer version of the Analytics SDK, too, so that's a bonus. Thanks again!

astjohn commented 9 years ago

No problem! Glad to hear that it's working.