Always-on editors with autoSave messing up dijit's popup manager

[szilardkiss]

Hi,

In case of using a grid with always-on editors and autosave, if the grid contains popup widgets, the dijit popup manager (popup.js) is having trouble (as in throwing script errors) cleaning up. This happens when filling in a text/number etc. editable field and activating next an editor widget with a popup (drop down button, selector, datetime widget, etc.)

The dgrid issues list contains related observations (most notably 'Always-on editors with autoSave: true #632') but these touch only one aspect of the problem, the focusing behavior.

Steps to reproduce:

• Go to http://dgrid.io/js/dgrid/test/Editor_autosave.html
• Generate a grid with editor type 'always-on'
• Edit the Number or Text fields without doing any closing action (like for instance pressing enter or clicking with the mouse) that would trigger an autosave
• Click with the mouse on a Date field's drop-down icon to activate the Calendar popup
• Every second time you repeat the last two steps, a script error will occur

For as far I can see, the following is happening:

• dgrid will do an autosave on the moment that the second editor is activated/the first one is deactivated
• this means that all widgets in the grid will be destroyed, leaving the popup manager in an incorrect state (the popup widget was created but not cleaned up from the stack)
• next time you repeat the action the popup stack will try to clean up the popup widget on the stack (not the current popup) but that was already destroyed, resulting in updates of null dom nodes which gives the error

This behavior is observed from dgrid version 0.3.14-dev through 0.3.15 and the current dgrid in action on the dgrid.io test pages (see link above).

Another issue/annoyance observed that might be related to this is that on dgrid 0.3.14-dev if you are using two grids with the conditions described above and you edit a field in one grid and you open a popup in the other grid, the popup in the second grid survives the autosave process triggered. This is not the case anymore for dgrid 0.3.15, there the popup gets closed.

I am happy to provide further explanations if required.

Thanks, Szilard

[RichAyotte]

I'm bypassing the problem by not notifying the grid when the store data has changed and avoiding the row deletion and re-creation.

https://gist.github.com/RichAyotte/bcfffe651b52eb97865a