SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 295 forks source link

Tree#expand behaves indistinguishably for unrendered-but-existing IDs and nonexistent IDs #1229

Open kfranqueiro opened 8 years ago

kfranqueiro commented 8 years ago

When Tree is used with a lazy-rendering grid (which is the norm, e.g. OnDemandGrid or Pagination), the expand method will currently end up throwing an error if an item ID is passed that is not currently rendered - whether it actually exists in the store or not. This is admittedly a likely rare case (compared to the usual case of expand being called as a result of direct user interaction on a row that is already rendered), but could lead to confusion.

I see 3 possible ways of addressing this: