search

SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 295 forks source link

dGrid 1.1 does not work with IE8 due to getElementsByClassName #1343

Closed yohanleafheart closed 7 years ago

yohanleafheart commented 7 years ago

Grettings all,

I know dGrid is not longer officially compatible with IE8 but there is a bug happening now which is probably easy to fix (it does not happen on 0.3). The .resize() function on OnDemandList uses getElementsByClassName which is not available on IE8, so it fails.

dylans commented 7 years ago

@yohanleafheart ok, fair enough... do you want to create a PR to speed that up? If not, no worries, we'll get to it for the next release.

yohanleafheart commented 7 years ago

Hey Dylans, by the way, I just realized I opened this same ticket 25 days ago, I'm sorry, I completely forgot about it. That issue is https://github.com/SitePen/dgrid/issues/1336#issuecomment-270705194 So I think it is probably better to close this as duplicate and use that one.

I have never done a PR on Github so not sure how to proceed on it, but the fix is on that other issue Just with a typo, it should be this.contentNode.querySelectorAll('.dgrid-row')

dylans commented 7 years ago

Thanks, will close this in favor of the other ticket.