search

SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 295 forks source link

bug? rowHeight not set #1355

Closed Jens-dojo closed 4 years ago

Jens-dojo commented 7 years ago

Hi all,

according to some discussions here (#1279), the OnDemandGrid should have a rowHeight property that reflects the average height of all rendered rows.

But the value seems to be always 0. I checked the source code and I couldn't find a place where it gets set? Only preload.rowHeight gets set.

Bug ?

dylans commented 7 years ago

@Jens-dojo could you share an example for how this is happening? It doesn't sound correct (could be a bug, or could be something in your use cases, etc.).

msssk commented 4 years ago

The value is set in the _updatePreloadRowHeights method and exposed as a grid property so that extensions can make use of it.