SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 295 forks source link

"Defining Grid Structures" Tutorial has screenshot mismatch #1396

Closed shenningsgard closed 6 years ago

shenningsgard commented 7 years ago

In the "Defining Grid Structures" tutorial, under the "Defining Sub-rows" section, there is a viewable demo showing an example of how sub-rows can be used. Although it is not explicitly mentioned, because the same data set is used as in the previous "Parts of the Grid" section, it is implied that the "Defining Sub-rows" code should match the screenshots shown in the "Parts of the Grid" section. However, this is not the case:

"Parts of the Grid" screenshot: image

"Defining Sub-rows" screenshot: dgrid_demo

It would be nice if these matched, so that users may review the code and look at the previous screenshots to compare, since they use the same data set.

edhager commented 6 years ago

I pushed a fix to the website that makes the subrows demo look more like the screenshot. It is not an exact match because the screenshot includes the column set definition which has not been added to the subrows demo.