search

SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 298 forks source link

Fix error in pure AMD definition function #1450

Closed rgcl closed 4 years ago

rgcl commented 4 years ago

The profile.resourceTags.amd function of the package.js file was set to discard the dgrid/css/nodes, dgrid/html-report directories as pure AMD. In this way, the dojo/util build process will not throw errors.

Without this, the build process throw this errors:

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dgrid/css/nodes/color-image; error: TypeError: Cannot read property 'nodes' of undefined

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dgrid/css/nodes/gradient; error: TypeError: Cannot read property 'nodes' of undefined

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dgrid/css/nodes/vendor-helpers; error: ReferenceError: module is not defined

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dgrid/html-report/prettify; error: ReferenceError: window is not defined

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dgrid/html-report/sorter; error: ReferenceError: window is not defined
msssk commented 4 years ago

Closing this as it has been fixed in #1454. Thank you for the fix and PR!