SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 298 forks source link

List: update byId to work with elements not in the document #1464

Closed msssk closed 4 years ago

msssk commented 4 years ago

dgrid's destroy method can silently fail to perform its job if the dgrid node has been detached from the DOM. In List#cleanup the call to byId only works for elements still in the DOM. This PR changes the byId method to use dojo/query and the context parameter so that descendants of the specified context can be retrieved even if context is detached from the DOM.

Fixes #1318