search

SitePen / dojo-amd-converter

A legacy dojo to AMD conversion utility.
Other
11 stars 5 forks source link

dojo.Deferred not converting #10

Open mmaxwell opened 11 years ago

mmaxwell commented 11 years ago

dojo.Deferred is not converting to dojo/Deferred.

francesmcmullin commented 11 years ago

Could you elaborate? When I simply did a require and new dojo.Deferred() it converted just fine, are you referring to the conversion from addCallback syntax to then?

kfranqueiro commented 11 years ago

This is actually another one that might be more of a rabbit hole than it first appears, given that if we wanted to convert fully to dojo/Deferred (which dojo.Deferred isn't), it would cause changes to the underlying API and would break any code using the old dojo/_base/Deferred behavior (such as addCallback). This is another one where I'd sooner err on the side of caution and not convert, rather than risk breaking people's code.

francesmcmullin commented 11 years ago

So you would be in favour of converting dojo.Deferred to dojo/base/Deferred, right?