SitePen / dojo-amd-converter

A legacy dojo to AMD conversion utility.
Other
11 stars 5 forks source link

Strange return value for "layer" module #24

Open mmaxwell opened 11 years ago

mmaxwell commented 11 years ago

A reasonably common pattern that's been used is a layer module that just requires in other modules but doesn't actually return anything - everything happens as a side effect of requiring in the other modules. The conversion for one of these is returning a value that is the global representing the namespace of this module but that global shouldn't exist when completely converted to AMD.

dojo.provide("stx.stxonlineLoginLayerModule");

dojo.require("stx.gui.Widget");

dojo.require("dijit.form.Button");
dojo.require("dojox.form.BusyButton");
dojo.require("dijit.form.Form");
dojo.require("dijit.form.TextBox");
dojo.require("dijit.layout.BorderContainer");
dojo.require("dijit.layout.ContentPane");
dojo.require("dojo.gears");
dojo.require("dojo.cookie");
dojo.require("dojox.sql");
dojo.require("stx.gui.Login");
dojo.require("stx.gui.ExtensionPrompt");
//more requires, add here

//IMPORTANT:This should be the last require 
//dojo.require("stx.app.module");

/*** end of lib.js requires **/

was converted to:

define(["stx/gui/Widget", "dijit/form/Button", "dojox/form/BusyButton", "dijit/form/Form", "dijit/form/TextBox", "dijit/layout/BorderContainer", "dijit/layout/ContentPane", "dojo/gears", "dojo/cookie", "dojox/sql", "stx/gui/Login", "stx/gui/ExtensionPrompt"], function (guiWidget, formButton, formBusyButton, formForm, formTextBox, layoutBorderContainer, layoutContentPane, gears, cookie, sql, guiLogin, guiExtensionPrompt) {
    //more requires, add here

    //IMPORTANT:This should be the last require 
    //dojo.require("stx.app.module");

    /*** end of lib.js requires **/
    return stx.stxonlineLoginLayerModule;
});

the strange part is what gets returned