search

SitePen / dojo-amd-converter

A legacy dojo to AMD conversion utility.
Other
11 stars 5 forks source link

_Templated not converting #27

Open mmaxwell opened 11 years ago

mmaxwell commented 11 years ago

_Templated is not converted to dijit/_TemplatedMixin.

Also, when a widget has widgetsInTempalte: true, the dijit/_WidgetsInTemplateMixin mixin should be added.

wkeese commented 11 years ago

I see you are already converting templatePath to templateString (and loading the template via dojo/text!).

The other minor point is that technically waiRole and waiState in templates should be converted (as explained in http://dojotoolkit.org/reference-guide/1.8/releasenotes/migration-2.0.html#releasenotes-migration-2-0), but maybe that's not important enough to worry about. I doubt many people are using those attributes.