SitePen / dojo-amd-converter

A legacy dojo to AMD conversion utility.
Other
11 stars 5 forks source link

dojo.connect to aspect.after conversion error #7

Closed mmaxwell closed 11 years ago

mmaxwell commented 11 years ago

It looks like the conversion from dojo.connect to aspect.after is not completely functional.

dojo.connect(this.firstPane, '_onLoadHandler', this, 'toggleFirstPaneOverlay');

was converted to

aspect.after(this.firstPane, '_onLoadHandler'lang.hitch(this, 'toggleFirstPaneOverlay'), true);

Between _onLoadHandler and lang.hitch, there should be a comma.

csnover commented 11 years ago

Resolved by 63c6059. Thanks @davecocoa for the PR.