SitePen / dstore

A data infrastructure framework, providing the tools for modelling and interacting with data collections and objects.
http://dstorejs.io/
Other
281 stars 83 forks source link

Dependency on @types/dojo #242

Closed HeikoStudt closed 3 years ago

HeikoStudt commented 3 years ago

Currently dstore is depending on @types/dojo due to #236 / #175, but there is also https://github.com/dojo/typings.

Former seems to be generated and does not have e.g. optional parameters (which breaks the usage of Xhr for us). Latter seems to be more precise, newer and handwritten (like having a generic Defereed) but by that incompatible to the former.

Because dstore is referencing @types/dojo as a dependency, we are not able to choose between the two. Currently we prefer the handwritten one, as everything not available is easily added type-less or possibly contributed by us.

There was a discussion to link from @types/dojo to dojo-typings some four years ago: https://github.com/dojo/typings/issues/39, so possibly the dojo-typings was the way to go.