SitePen / dstore

A data infrastructure framework, providing the tools for modelling and interacting with data collections and objects.
http://dstorejs.io/
Other
281 stars 83 forks source link

update test instructions #9

Closed neonstalwart closed 10 years ago

neonstalwart commented 10 years ago

i'm trying to submit a PR to change the 'dojo/request/registry' dependency in Rest.js to 'dojo/request' but i can't get the tests to run according to the instructions.

i realized that npm install intern should be npm install intern-geezer but then i see a few 404s for rql and json-schema. are these supposed to be available too?

also, it would be preferable if it were possible to run the dstore tests by only changing things inside of the dstore directory rather than siblings - i.e. installing intern into dstore/node_modules. it's not a critical issue but it just means that i have to prepare a parent dir for dstore that is suitable for dstore development rather than developing directly from the dstore clone.

neonstalwart commented 10 years ago

i got the tests to run by cloning dojo, persvr/rql, and kriszyp/json-schema but one test failed:

AssertionError: Object schema properties should still be set even if passed a non-Object value

did i use the right libraries?

brandonpayton commented 10 years ago

@neonstalwart, I'm glad to have your eyes on dstore.

All tests pass for me when I run them with intern, but I get the same failure as you with intern-geezer. It looks like a test bug caused by geezer's deepEqual implementation differing from chai's. I'll take a quick look.

Regarding your PR, another person mentioned it this afternoon, and @kriszyp pushed a fix.

brandonpayton commented 10 years ago

@neonstalwart, it sounds like you're using the correct libraries.

On a second look, I think the Model test failure is legitimate. We'll have to discuss that with @kriszyp as I'm not deeply familiar with dstore modeling.

brandonpayton commented 10 years ago

I updated dstore's package.json so test dependencies can be installed with npm install and updated the documentation.

Closed via 8216074d190525d4da760b4d8c4182391af218ac

brandonpayton commented 10 years ago

We ended up removing the failing Model assertion as it wasn't important enough to justify work to fix it.

neonstalwart commented 10 years ago

:+1: