search

Sitecore / Habitat

Sitecore Modular Architecture Example
Other
413 stars 397 forks source link

Fixed Multisite current site evaluation issue: the site selector does… #465

Open peternazarov opened 5 years ago

peternazarov commented 5 years ago

Fixed Multisite current site evaluation issue: the site selector does not show the current site selection based on the current Site context.

Implementation note: maybe SiteDefinition should just have the corresponding extension method instead of "IsCurrent" property. Then the extension method can be unit tested in isolation. However, it would make the coding less intuitive because you will not observe the extension method from IntelliSense unless the extension method class's namespace is exposed to the context.

nickwesselman commented 5 years ago

@gbxe Thanks for the PR, but not sure I understand the issue being solved here. Is there a bug in Habitat itself that you have reproduction steps for, and if so can you open a related Issue? Or is it a problem encountered when reusing this module in another solution?

Thanks!

peternazarov commented 5 years ago

image

When you switch the site, the current site highlight does not change.

I have just completed Helix Workshop in Munich, Germany, where I discovered that issue and fixed it.

I think IsCurrent property should not be part of the data model because of its value is Site context dependent. However, there would be more Habitat solution code refactoring required. Please review the fix and evaluate whether it is good enough in your perspective.

peternazarov commented 5 years ago

This is the fix for https://github.com/Sitecore/Habitat/issues/466