search

Sitecore / Reference-Storefront

Sitecore Reference Storefront
Other
25 stars 20 forks source link

Unknown characters in GlobalSuppression.cs files #2

Open brianhdk opened 8 years ago

brianhdk commented 8 years ago

This might be a local issue, but I've tried to clone the repository on different machines, and on every machine I'm unable to build the solution, because of strange chinese-looking characters in the GlobalSuppresion.cs file.

See the following screen-shot from VS: https://dl.dropboxusercontent.com/u/4142207/globalsuppression.JPG

Have you guys experienced this before - or know how to solve it?

It's the same issue if I download the ZIP file containing the source code. But the issue is not present in the previous release. Hope it helps.

Thanks

brianhdk commented 8 years ago

See the following Stack Overflow: http://stackoverflow.com/questions/17515768/git-messed-up-my-files-showing-chinese-characters-in-some-places

Thanks @larrelandin

SorenKerrn commented 8 years ago

It's not a known issue or something we have seen before. We will try it out and see if we can reproduce the issue

SorenKerrn commented 8 years ago

As it turns out, we have seen it on same instances and it seems to be GIT related. We have provided a PowerShell script that can help you out. It's located with the release and named UnixToWindowsEOL.zip. And you will likely encounter more instances than the GlobalSuppresion.cs file, which the script will fix

larrelandin commented 8 years ago

@SorenKerrn That script seems to be designed only for items handled by TDS. This is another problem I am afraid.

DThrasher commented 8 years ago

I think the bad characters have been checked into the repository somehow. I ran the UnixToWindowsEOL.ps1 conversion script with the following parameters:

..\UnixToWindowsEOL.ps1 -path 'C:\Projects\Reference-Storefront' -include 'GlobalSuppressions.cs'

But this did not resolve the issue. The earlier stackoverflow issue referenced by @brianhdk is spot on; it's definitely a UTF16LE encoding issue.

SorenKerrn commented 8 years ago

We will take a look at it and make sure that the checked in source is in the correct format

SorenKerrn commented 8 years ago

A new version of the source code files was pushed to the repository where the file formats have been fixed. It's tagged 8.1.478.2