Closed thomas-desmond closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| sitecore-migration-game | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 14, 2023 7:12pm |
dylanyoung-dev
commented
1 year ago Is it just me, or is the only tests I see running in our job, the components, not the E2E? That's more than likely an issue with the modifications I made it the last PR. I was wondering maybe we should create two jobs, one is "E2E Tests" and the other "Component Tests" and that might be more helpful for Jason because he will likely only really need to run E2E tests, whereas both test types should run on push.
dylanyoung-dev
commented
1 year ago But your specific changes look good. I'd say we may want to speak with Jason on which tests would be helpful for him to confirm that he's not breaking things. I was wondering maybe a test for each type. So maybe an XM, XP, and XC tests, for both Fantasy and Corporate. Possibly, or maybe it shouldnt be like that, maybe it should just be to confirm resources and certain products light up appropriately.
But I think this looks good to go! (but maybe we should add to this PR separating the two test jobs)
dylanyoung-dev
commented
1 year ago Changes look good!
A poorly named branch because one test is for the outcome page while the second is for theme switching.
But two additional e2e tests. We should talk more on how we want to build these out and what sort of coverage we are interested in.