Sitecore / Sitecore.Pathfinder

Get started, get far, get happy!
Other
34 stars 12 forks source link

Config file read permissions errors #47

Closed JakobChristensen closed 7 years ago

JakobChristensen commented 8 years ago

When trying to run the import-website task I was getting an error about configuration files not being found. This is because the Pathfinder server component was trying to interact with my project files. This feels a bit weird. As a server component, it should just do its work and pass the results back to the caller. In the case where we need the global and/or project config, the console app should pass the config to the server in the web request. So for when calling the webapi, change the calls to POSTs and in the body send over the fully patched config required. This eliminates the need for the server to read a project file outside the Webroot. Having to grant read permissions to the web app identity in my project source feels a bit weird. Likewise, it would appear this task will write the files directly to the project directory. This again feels a little odd and requires permissions to write to my project directory for the web identity user. It feels a bit more natural for the task to just return the generated files (or data for the files) in the response of the web request. I know at the moment Pathfinder must run on the same machine as the instance we’re interacting with, but I can see in the future extending the tool to handle deployments to the QA environment or to the demo server from the build server.

JakobChristensen commented 8 years ago

For now: if WebApi tasks do not have read/write access to tools and project directory, the website server returns an error.