Sitecore / Sitecore.Rocks

Sitecore Rocks is a plugin for Visual Studio for Sitecore developers.
Other
75 stars 27 forks source link

Text color doesn't change with theme change(dark) VS Studio. #136

Open writemaster91 opened 4 years ago

writemaster91 commented 4 years ago
  1. Changing Theme in Visual Studio (2019) to Dark (Not VS Standard)
  2. Text changes in VS to light (white) / adapting to the background color. image

ISSUE. Text color doesn't change in Sitecore Explorer window. image

Expected Result: Text color should be white or at least light when a dark color scheme is set.

drw-89 commented 4 years ago

I have the same, there seems no way to fix this properly.

nickwesselman commented 4 years ago

@writemaster91 @drw-89 As a workaround, can you try restarting Visual Studio after switching to Dark Theme and see if that resolves the issue?

writemaster91 commented 4 years ago

@nickwesselman The problem seems to be when you use another Theme that is not "VS standard Dark" but a theme that is from an extension that has a "darkmode"

Because the workaround work otherwise. But if I have a dark theme(not a VS standard) and start VS I get the error described above then I have to do the following steps every time to fix it:

nickwesselman commented 4 years ago

Thanks for the additional info @writemaster91. What's an example of an extension theme you have experienced this with?

drw-89 commented 4 years ago

I think I found the issue. 'Sitecore.Rocks.VisualStudio/Shell/Pipelines/Initialization/005 - SetTheme.cs' GetVisualStudioTheme() checks if the current VSColorPaint is a certain colour (I guess the standard Dark Theme's grey), and sets isDark to true, next to that it checks if the current theme's ID contains a certain guid (again I guess the standard Dark Theme's ID). Only if one or both is true, the function returns AppTheme.Dark. So the function basically assumes that if it's not the exact same VSColorPoint or Theme ID, it isn't a Dark Theme.

writemaster91 commented 4 years ago

Thanks for the additional info @writemaster91. What's an example of an extension theme you have experienced this with?

@nickwesselman

image

image

vinylflamingo commented 3 years ago

I'm experiencing this issue. Has any resolution been found?