search

Sitecore / XM-Cloud-Introduction

A repository containing the code for the MVP & SUGCON Sites, powered by XM Cloud
47 stars 47 forks source link

Filters are not working perfectly #425

Open gauravpansari1991 opened 3 months ago

gauravpansari1991 commented 3 months ago

Describe the bug When I select 2024 and the United Arab Emirates facet then it is also showing the Jordan facet and its 1 result along with UAE profile cards

To Reproduce Steps to reproduce the behavior:

  1. Go to https://mvp.sitecore.com/en/Directory/
  2. Select '2024' in year filter
  3. Select 'United Arab Emirates' in country filter
  4. It should only show profiles of UAE but it is also showing 1 Jordan entry
image

Expected behavior It should only show 10 results of the United Arab Emirates.

sc-ivanlieckens commented 3 months ago

@gauravpansari1991 this result is actually correct due to this particular person having been MVP in multiple countries: image

@mrtamasvarga would you want this altered so it only takes "current" country into account or do we leave it to surface all countries of the MVP?

gauravpansari1991 commented 3 months ago

@sc-ivanlieckens makes sense but looks a little bit weird in the UI. Also, this is working fine for my profile though, as I was MVP in India for 3 years and then moved to Dubai, but my profile is not showing in India.

Also, it should show 11 counts in the United Arab Emirates as well I guess @sc-ivanlieckens

sc-ivanlieckens commented 3 months ago

@gauravpansari1991 well when I look at your titles none of them are in India? So logical that yours isn't showing in India. image

I can correct your title data to fix this. What years should I change to India?

I'll need to check the facet counting because it seems that results can't be counted twice which does give a slight miscount there.

gauravpansari1991 commented 2 months ago

@sc-ivanlieckens 2017, 2021, 2022 should be tagged to India.

IvanLieckens commented 1 month ago

@gauravpansari1991 I have updated the records so that should resolve this issue

robearlam commented 3 weeks ago

@IvanLieckens - Having a think about this, I agree it seems strange to have what looks like an incorrect country included in the results, even if the data is correct.

Instead of listing all applicable countries on the results listing page, which could get messy fast. What do you think about changing it say "Multiple" for MVP profiles who have awards from different countries?

sc-ivanlieckens commented 2 weeks ago

@robearlam or maybe do a flyout with countries on hover or something?

robearlam commented 2 weeks ago

@robearlam or maybe do a flyout with countries on hover or something?

Love that idea, the listing could say "Multiple" then have a hover listing the countries!