search

Sitecore / XM-Cloud-Introduction

A repository containing the code for the MVP & SUGCON Sites, powered by XM Cloud
47 stars 47 forks source link

Type and Year filters are not in sync #427

Open gauravpansari1991 opened 4 months ago

gauravpansari1991 commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://mvp.sitecore.com/en/Directory
  2. Click on Commerce Type Filter
  3. It shows filtered Year facets, select 2024 from the year filter
  4. It is showing 8 results for Technology and Ambassador MVPs
  5. Also it should not show other Type filters like Ambassador and Technology

Expected behavior 2024 doesn't have any commerce MVPs, so either we should hide 2024 or make it disable with zero count

Screenshots

image
sc-ivanlieckens commented 4 months ago

@gauravpansari1991 this result is actually again expected. The 8 people you're looking at were Commerce MVPs in the past and are MVP in 2024. So the combination of the facets isn't happening exactly as you expect (it evaluates people and all their titles, not titles separately)

@mrtamasvarga we discussed this shortly "what feels logical" how facets behave inside themselves and towards other facets. Do you believe this should change?

gauravpansari1991 commented 4 months ago

@sc-ivanlieckens Makes sense, just for suggestion in this case we can show the Commerce Category as well in the profile while the facet is on.

sc-ivanlieckens commented 3 months ago

@gauravpansari1991 I'm not sure I understand entirely what you mean by that? The profile always shows all titles and is a different page? Are you referring to the result cards?

gauravpansari1991 commented 3 months ago

@sc-ivanlieckens Yeah I am referring to profile cards, sorry for the confusion. I just have a suggestion that we can also show the commerce category as a comma-separated category list in profile cards but it's a business decision.