[templates/nextjs] [sitecore-jss-nextjs] [sitecore-jss] Remove partial rendering implementation (EditingComponentPlaceholder component) - Githubissues

Sitecore / jss

Software development kit for JavaScript developers building web applications with Sitecore Experience Platform

https://jss.sitecore.com

Apache License 2.0

263 stars 275 forks source link

[templates/nextjs] [sitecore-jss-nextjs] [sitecore-jss] Remove partial rendering implementation (EditingComponentPlaceholder component) #1821

Closed yavorsk closed 5 months ago

yavorsk commented 5 months ago

[x] This PR follows the Contribution Guide
[x] Changelog updated
[x] Upgrade guide entry added

Description / Motivation

This PR removes the EditingComponentPlaceholder implementation as it will not be used by Pages in this form: consists of:

removing the component implementation and unit tests;
adjusting nextjs template;
adjusting editing render middleware and unit tests;
remove "node-html-parser" dependency in sitecore-jss-nextjs;
removing constants and RenderingType enum from base package;

Testing Details

[x] Unit Test Added/Removed
[x] Manual Test/Other (Please elaborate) - smoke test nextjs app

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko commented 5 months ago

@yavorsk Let's update the title a bit a be more specific on the feature, e.g. "[templates/nextjs] [sitecore-jss-nextjs] [sitecore-jss] Remove Partial Rendering implementation"