[angular][xmcloud] Do not initialize CloudSDK if we are in edit or preview mode - Githubissues

Sitecore / jss

Software development kit for JavaScript developers building web applications with Sitecore Experience Platform

https://jss.sitecore.com

Apache License 2.0

263 stars 275 forks source link

[angular][xmcloud] Do not initialize CloudSDK if we are in edit or preview mode #1961

Closed yavorsk closed 3 weeks ago

yavorsk commented 3 weeks ago

[x] This PR follows the Contribution Guide
[x] Changelog updated
[ ] Upgrade guide entry added

Description / Motivation

This PR modifies cloudsk init component to not initialize CloudSDK in the browser if we are in edit or preview mode or route data is missing.

Testing Details

[ ] Unit Test Added
[x] Manual Test/Other (Please elaborate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko commented 3 weeks ago

@yavorsk Another thing that I observed, that when I navigate using client side routing - cloudsdk is initialized on each route change, while it should be initialized once, on the first visit. Also I don't know if it's fine for cloudsdk if "init" will be called multiple times