Sitefinity / amazon-s3-provider

Amazon S3 provider for Sitefinity
8 stars 9 forks source link

New Functionality to support a Key Prefix and EC2InstanceProfile IAM #9

Open BenWolstencroft opened 6 years ago

BenWolstencroft commented 6 years ago

A number of commits here:

Adds the ability to optionally supply a KeyPrefix parameter which allows the amazon-s3-provider to store files in a subfolder in the specified S3 bucket

Adds the ability to optionally use an EC2 Instance Role (i.e. not supply AccessKey and SecretAccessKey IAM credentials), this works if Sitefinity is deployed to an EC2 instance, and the EC2 instance's profile role has the correct S3 Bucket policy applied.

BenWolstencroft commented 6 years ago

Found an issue with the PR, will resubmit

BenWolstencroft commented 6 years ago

issue investigated and there was no problem - misconfiguration on my end!

ghost commented 5 years ago

Why was this not this PR merged?? This is a really useful feature!!

BenWolstencroft commented 5 years ago

@jxt-aref - don't think sitefinity 'care' much about this repo, seems it's more of a documentation example than a 'working' plugin