search

Sitefinity / feather-packages

Other
38 stars 33 forks source link

NPM error on "start" script in Bootstrap4 ResourcePackage #375

Closed fnicollier closed 5 years ago

fnicollier commented 5 years ago

Getting an "ReferenceError: Unknown plugin "transform-runtime" specified in..." when "doing npm start". I have ran "npm install" beforehand with not errors but babel-core's "option-manager.js" throws this exception because it claims it cannot find the transform-runtime plugin.

nikistefanov commented 5 years ago

Hello @fnicollier Can you give us more information about what node and npm version you are using. Also do you have additional dependencies listed in the package.json?

fnicollier commented 5 years ago

Hi @nikistefanov, I have Node V11.1.0 and npm V6.4.1. I'm using the package.json as provided in this repo. Thanks

nikistefanov commented 5 years ago

Hi @fnicollier

Unfortunately, the current state of Bootstrap 4 package is optimized for Node.js version 8.9.4 as this was the LTS during the development of the package. We have plans to upgrade this dependency to LTS 10.13.0 in the upcoming Sitefinity patches.

Could you switch to Node.js 8.9.4 and do the same steps.

I’ve tried to reproduce your issue using your Node.js version but I didn’t get the same error. If you still have this error with Node.js 8.9.4, try manually installing the missing dependencies.

For example: npm install babel-plugin-transform-runtime npm install babel-preset-stage-2 npm install babel-preset-es2015

Hope this would help.

fnicollier commented 5 years ago

I've downgraded my Node version to 8.9.4 and still got the same error. Even after installing the additional packages. Is it possible to add the package-lock.json to the Git repo? It is advised to commit that file.

nikistefanov commented 5 years ago

@fnicollier

I’m sending you package-lock.json. Please make sure you’ve removed all node_modules and you’re using Node.js 8.9.4 before doing npm install and npm start. package-lock.zip

fnicollier commented 5 years ago

Thanks. Removed the node_modules, reset the package.json, added the provided package-lock.json. Ran with Node 8.9.4 and I'm still getting the same babel-core error when the script hits the copy:js part.

fnicollier commented 5 years ago

Strange, I've created a new SF 11.1 project, ran npm install/start and there is worked fine as long as my cmd prompt was run as admin. I've copied the Boostrap4 folder to replace the one I was having problems with and I there I get the problems again. May be something to do with the dept of the folders or permissions.

fnicollier commented 5 years ago

OK I've nailed down the problem: if my Boostrap folder is under a structure with a "src" folder, this seems to break the copy:js script. If I rename the src folder in the structure to anything else it works.

nikistefanov commented 5 years ago

Hi @fnicollier We were able to reproduces the issue. We will fix it for the next release. Thanks for the feedback.

fnicollier commented 5 years ago

Thank you.

nikistefanov commented 5 years ago

Hi @fnicollier Could you please verify if the issue is still relevant with the latest commit?

fnicollier commented 5 years ago

Hi and happy new year.

I've updated my project to SF 11.2.6900.0 and I'm happy to confirm that the Bootstrap4 resource package now builds perfectly even under a "src" folder structure.

Thank you.