search

Sitefinity / feather

mvc
Other
97 stars 68 forks source link

Solve Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always change/update first sf-media-field control. Also bug present when having sf-auto-open-selector attribute present in sf-media-field always open first sf-media-field #2716

Open Abhijeet2019 opened 2 years ago

Abhijeet2019 commented 2 years ago

Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always update first sf-media-field element. Also bug present when having sf-auto-open-selector attribute presents always open first sf-media-field.

code lines added //Add below lines of code to solve multiple sf-media-field selector in same designer view if (mediaElement && mediaElement.length > 0) { var el = mediaElement[0].querySelector('.mediaSelectorModal'); if (el) { var ngEl = angular.element(el); if (ngEl) { mediaSelector = ngEl; } } }

stefankoserkov commented 2 years ago

Hello @Abhijeet2019.

Thank you for submitting this item, reporting this bug and a fix. I wanted to let you know that this repository is intended to be used for reference for our customers, and this PR will not be merged here, we will fix this issue internally and we will ship it with a patch.

In all likelihood this fix will be shipped with the first patch for Sitefinity 14.3.

Best regards, Stefan

Abhijeet2019 commented 2 years ago

Thanks @stefankoserkov. I am getting this issue since from version 11.x and I have above workaround takes place in our code but when I upgrade to 14.2 issue still persist and I thought of sharing this workaround so in future version/patch it will be available.

Regards, Abhijeet