search

Siteimprove / CMS-plugin-Episerver

0 stars 7 forks source link

Added a SiteimproveAdmins role to authorize attribute in controllers #2

Closed kwillumsen closed 7 years ago

kwillumsen commented 7 years ago

Need to give access to Siteimprove overlay in Epi CMS edit mode for user not in Administrators, WebAdmins, CmsAdmins. Added new role SiteimproveAdmins for this

CasperTDK commented 7 years ago

Should it not be CmsEditors instead?

kwillumsen commented 7 years ago

Could be if the purpose of the module is to give access to editors as well. I just followed your "Admin" roles setup :) Maybe the Roles in Authorize attribute for SiteimproveController and SiteimproveAdminController should differ. "Editors" roles in SiteimproveController and "Admins" roles in SiteimproveAdminController

Our customer have users (Uses windowsmembership and role provider) that isn't in an admin role and shouldn't be but still needs to have access to the module. For that purpose we need that extra role added so we can do this in 

<episerver.framework><virtualRoles><providers>

<add name="SiteimproveAdmins" roles="domain\rolename" mode="Any" type="EPiServer.Security.MappedRole, EPiServer" />
CasperTDK commented 7 years ago

Alright. That makes sense. I will review and merge the ticket!

CasperTDK commented 7 years ago

I've pushed the package to episerver, pending their nuget approval - it can take a few days

kwillumsen commented 7 years ago

Great thanks

CasperTDK commented 7 years ago

Hi @kwillumsen It is out: http://nuget.episerver.com/en/OtherPages/Package/?packageId=SiteImprove.EPiServer.Plugin