search

Siterizer / new-world-fishing-bot

user friendly python script who is able to catch fish in the game New World
GNU General Public License v3.0
294 stars 124 forks source link

v2.0.0 Problem with false positive fish detection. #237

Closed phGH closed 2 years ago

phGH commented 2 years ago

Botting on vmware, All was working fine with v1.2.1, but on v2.0.0 getting a lot of false positive fish detection. Any ideas how it can be solved?

https://user-images.githubusercontent.com/92539302/139595326-d4fa5ef1-3267-4e9d-b00c-c1b75bf512d3.mp4

ryanmcadams commented 2 years ago

How'd you get this to run on vmware? I cannot get it to run in a VM for the life of me.

phGH commented 2 years ago

vm v16.1.1 nothing special. 2c2t 6gb ram. There was no problem with vm for me.

4rak007 commented 2 years ago

Same problem

frankfuu commented 2 years ago

Might be unrelated but i find that fishing in areas where there is less green and red tends to help.

phGH commented 2 years ago

Might be unrelated but i find that fishing in areas where there is less green and red tends to help.

The thing is that v1.2.1 working like a charm (except camera drifting).

Siterizer commented 2 years ago

Think i know what's the issue. Color wages jumped from 7: https://github.com/Siterizer/new-world-fishing-bot/blob/main/functionality/image_recognition.py To 4: https://github.com/Siterizer/new-world-fishing-bot/blob/2.0.0/utils/global_variables.py Maybe will put this thing into config and make 7 default 🤔

Edit: Oh wait it's about 'notice' detection. May i Ask You what's the resolution your game works on?

phGH commented 2 years ago

Think i know what's the issue. Color wages jumped from 7: https://github.com/Siterizer/new-world-fishing-bot/blob/main/functionality/image_recognition.py To 4: https://github.com/Siterizer/new-world-fishing-bot/blob/2.0.0/utils/global_variables.py Maybe will put this thing into config and make 7 default 🤔

Edit: Oh wait it's about 'notice' detection. May i Ask You what's the resolution your game works on?

Game runs on 1280x720. I just replaced images in resource folder with my own from 1280x720 resolution. Worked very good on v1.2.1 With v2.0.0 I tried with stock images and replaced images (as I did with v1.2.1) and I'm getting that false positive fish detection with any images.

If it can be done like before as an option in condig it would be very cool.

Siterizer commented 2 years ago

Sorry, end of the support. Statement: https://github.com/Siterizer/new-world-fishing-bot#new-world-fishing-bot-end-of-support