Siudya / ORB_FPGA

69 stars 26 forks source link

Does the code here support NPC >1? #2

Closed JianmingTONG closed 1 year ago

JianmingTONG commented 4 years ago

I found several lines below, and it seems that the original code

469     if(NPC == XF_NPPC8)
470     {
471     }

If NPC equals XF_NPPC8, the module will have no output. And in the else branch, the code only implements one pixel's judgement. Similar operations could be seen in other module.

Siudya commented 4 years ago

My codes are based on XfOpencv and reserve the structure ( FAST.hpp actually ). XfOpencv supports processing 8 pixels a time, but my design does not as the resources on xc7z020 is limited and doing so may lower the frequency. Sorry for the bad coding style and I hope it doesn't bother you much.

------------------ 原始邮件 ------------------ 发件人: "Jianming"<notifications@github.com>; 发送时间: 2020年7月31日(星期五) 下午2:26 收件人: "Siudya/ORB_FPGA"<ORB_FPGA@noreply.github.com>; 抄送: "Subscribed"<subscribed@noreply.github.com>; 主题: [Siudya/ORB_FPGA] Does the code here support NPC >1? (#2)

I found several lines below, and it seems that the original code 469 if(NPC == XF_NPPC8) 470 { 471 }
If NPC equals XF_NPPC8, the module will have no output. And in the else branch, the code only implements one pixel's judgement. Similar operations could be seen in other module.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

JianmingTONG commented 4 years ago

Thanks for the reply and your open-source code. I study lots of tricks & templates on using xfOpencv.