search

Sivapsg / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

Envelope quotation marks are removed by CSV importer #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Import a CSV or TSV file with a data value of: "\"value1\""
On import the value becomes "value1"

For most cases this won't be a problem, except where it's a
description which starts or ends with a quotation mark e.g.: "\"To be
or not to be\" is a quote from Hamlet."

This gets garbled into "To be
or not to be\" is a quote from Hamlet."

Original issue reported on code.google.com by iainsproat on 16 May 2010 at 5:47

GoogleCodeExporter commented 9 years ago 
Actually, it appears that quotation marks should be double quoted.

e.g."\"\"To be
or not to be\"\" is a quote from Hamlet."

http://publib.boulder.ibm.com/infocenter/wmbhelp/v6r1m0/index.jsp?
topic=/com.ibm.etools.mft.doc/ad20830_.htm

Original comment by iainsproat on 16 May 2010 at 6:11

GoogleCodeExporter commented 9 years ago 
So it looks like the original csv parser did work correctly?

Iain, I think your patch has lost the functionality of auto-detecting between 
TSV and CSV. Now, I think it'd always 
assume CSV. Could you please fix it or revert the patch?

Original comment by dfhu...@gmail.com on 17 May 2010 at 12:41

GoogleCodeExporter commented 9 years ago 
Good catch - I'll fix it (and add some tests)

Original comment by iainsproat on 17 May 2010 at 2:48

GoogleCodeExporter commented 9 years ago 
David, could you check r787?

I've reverted to your parser, but there are 4no tests failing. I've ignored 
them for 
the moment (enabled=false) - could you also check they are valid tests, that 
the 
behaviour I've assumed is as you would expect?

Original comment by iainsproat on 17 May 2010 at 3:26

GoogleCodeExporter commented 9 years ago 
Iain, they should pass now. I'm closing this bug.

Original comment by dfhu...@gmail.com on 17 May 2010 at 5:28

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:21

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:56