search

SiverDX / additional_enchantments

MIT License
0 stars 0 forks source link

[Bug]: Weird arrow behavior when using Explosive Tip Enchantment #2

Closed Jouto55 closed 7 months ago

Jouto55 commented 7 months ago

When using the Explosive Tip enchantment, the arrows behave weirdly.

https://github.com/SiverDX/additional_enchantments/assets/148708399/188bf04a-2f7b-4934-81fd-40135854b262

This behavior also extends to Tridents, and Crossbows.

Mods:

Minecraft Version: 1.20.1 Mod Loader: Forge 47.2.19 OS: Windows 11

SiverDX commented 7 months ago

seems to be due to a difference in forge & neoforge codebase this mod is developed using neoforge as basis for 1.20+

not sure if this will be addressed

Jouto55 commented 7 months ago

seems to be due to a difference in forge & neoforge codebase this mod is developed using neoforge as basis for 1.20+

not sure if this will be addressed

Didn't cpw say that NeoForge 1.20.1 was gonna be compatible with 1.20.1 Forge?

Are there major differences in 1.20.1 NeoForge that would cause difficulty in fixing this bug? Or you'll have to split the mod into separate Forge and NeoForge mods?

SiverDX commented 7 months ago

https://github.com/PaintNinja/MinecraftForge/commit/2f229c5bb1dd6c8db70e3daac2aad05948ad12a8

It's this to be exact

NeoForge did not do this change: https://github.com/neoforged/NeoForge/blob/1.20.x/patches/net/minecraft/world/entity/projectile/AbstractArrow.java.patch

Jouto55 commented 7 months ago

PaintNinja/MinecraftForge@2f229c5

It's this to be exact

NeoForge did not do this change: https://github.com/neoforged/NeoForge/blob/1.20.x/patches/net/minecraft/world/entity/projectile/AbstractArrow.java.patch

Hmm. Given that NeoForge is now diverging from Forge, the best thing to do at this point is to either.

A. Take the easy route and just ignore the bug.

B. Split the mod into NeoForge and Forge versions so the bug is fixed on the Forge side of things.

IDK if convincing the NeoForge team to do the exact change to projectiles that Forge did is in the realm of possibility.

SiverDX commented 7 months ago

well there is this https://github.com/neoforged/NeoForge/pull/23

since the forge implementation regressed when doing this change (not considering blocks and only caring about entity hits) it wouldn't be much use for me atm

will probably have to do a mixin which only loads for forge

SiverDX commented 7 months ago

fixed in https://www.curseforge.com/minecraft/mc-mods/additional-enchantments/files/5059564

Jouto55 commented 7 months ago

Tested the mod with fix, arrows now behave normally. 👍