SixLabors / Fonts

:black_nib: Font loading and layout library.
https://sixlabors.com/products/fonts
Other
306 stars 71 forks source link

Improve metrics APIs to make them more useful. #323

Closed JimBobSquarePants closed 1 year ago

JimBobSquarePants commented 1 year ago

Prerequisites

Description

@ThomasMiz I'd really like to discuss any further improvements we can add and any issues you have. Your input is really valuable here as it's difficult for us to ensure use cases are covered since our own are quite narrow.

codecov[bot] commented 1 year ago

Codecov Report

Merging #323 (ae2a33f) into main (18401a0) will increase coverage by 0%. The diff coverage is 77%.

@@          Coverage Diff           @@
##            main    #323    +/-   ##
======================================
  Coverage     83%     83%            
======================================
  Files        224     224            
  Lines      12331   12439   +108     
  Branches    1790    1790            
======================================
+ Hits       10306   10424   +118     
+ Misses      1603    1597     -6     
+ Partials     422     418     -4     
Flag Coverage Δ
unittests 83% <77%> (+<1%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SixLabors.Fonts/FontMetrics.cs 100% <ø> (ø)
src/SixLabors.Fonts/GlyphBounds.cs 83% <ø> (ø)
...nts/Tables/AdvancedTypographic/GPos/AnchorTable.cs 34% <0%> (-3%) :arrow_down:
src/SixLabors.Fonts/Tables/Cff/CffBoundsFinder.cs 69% <0%> (-2%) :arrow_down:
...bors.Fonts/Tables/Cff/TransformingGlyphRenderer.cs 51% <0%> (-3%) :arrow_down:
src/SixLabors.Fonts/GlyphRendererParameters.cs 59% <38%> (-4%) :arrow_down:
src/SixLabors.Fonts/Font.cs 53% <52%> (-5%) :arrow_down:
src/SixLabors.Fonts/StreamFontMetrics.cs 83% <61%> (-4%) :arrow_down:
src/SixLabors.Fonts/GlyphMetrics.cs 73% <70%> (+22%) :arrow_up:
...Tables/AdvancedTypographic/Shapers/HangulShaper.cs 83% <75%> (+<1%) :arrow_up:
... and 14 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more