SixLabors / ImageSharp.Drawing

:pen: Extensions to ImageSharp containing a cross-platform 2D polygon manipulation API and drawing operations.
https://sixlabors.com/products/imagesharp-drawing/
Other
285 stars 39 forks source link

Use Shared props/targets #111

Closed JimBobSquarePants closed 3 years ago

JimBobSquarePants commented 3 years ago

Prerequisites

Description

codecov[bot] commented 3 years ago

Codecov Report

Merging #111 (f9b7929) into master (3d737b5) will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   70.82%   71.01%   +0.19%     
==========================================
  Files          86       86              
  Lines        5600     5465     -135     
  Branches     1119     1119              
==========================================
- Hits         3966     3881      -85     
+ Misses       1409     1359      -50     
  Partials      225      225              
Flag Coverage Δ
unittests 71.01% <ø> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ImageSharp.Drawing/Shapes/RectangularPolygon.cs 88.19% <0.00%> (-0.55%) :arrow_down:
src/ImageSharp.Drawing/Processing/SolidBrush.cs 92.10% <0.00%> (-0.40%) :arrow_down:
src/ImageSharp.Drawing/Processing/PatternBrush.cs 85.41% <0.00%> (-0.30%) :arrow_down:
src/ImageSharp.Drawing/Shapes/Star.cs 92.30% <0.00%> (-0.29%) :arrow_down:
src/ImageSharp.Drawing/Shapes/ComplexPolygon.cs 74.78% <0.00%> (-0.22%) :arrow_down:
...arp.Drawing/Shapes/Rasterization/ActiveEdgeList.cs 98.14% <0.00%> (-0.15%) :arrow_down:
src/ImageSharp.Drawing/Shapes/Clipper/clipper.cs 48.08% <0.00%> (-0.12%) :arrow_down:
src/ImageSharp.Drawing/Shapes/InternalPath.cs 90.22% <0.00%> (-0.11%) :arrow_down:
src/ImageSharp.Drawing/Shapes/Outliner.cs 95.40% <0.00%> (-0.11%) :arrow_down:
src/ImageSharp.Drawing/Shapes/PathBuilder.cs 93.58% <0.00%> (-0.09%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d737b5...f9b7929. Read the comment docs.

JimBobSquarePants commented 3 years ago

Didn't get to drawing yet, but I see 999 build warnings in main lib's ImageSharp.Test project per build target. We should fix that before propagating the changes further.

I don't think your submodule is loaded properly or something. I brought it down to zero from over 1200 warnings.

is-d-sdk is-d-sdk-jb

antonfirsov commented 3 years ago

@JimBobSquarePants ah sorry you may be right will doublecheck tomorrow! Forgot that sobmodule update typically goes always wrong 😅

antonfirsov commented 3 years ago

Opened SixLabors/ImageSharp#1460 to properly track the problem.