SixLabors / ImageSharp.Web

:globe_with_meridians: High Performance Image Processing Middleware for ASP.NET- Core.
https://sixlabors.com/products/imagesharp-web/
Other
423 stars 101 forks source link

Add GrayscaleWebProcessor #313

Closed stefannikolei closed 1 year ago

stefannikolei commented 1 year ago

Prerequisites

Description

Adds an Grayscale processor as in #310

codecov[bot] commented 1 year ago

Codecov Report

Merging #313 (75f32e2) into main (135c8b1) will decrease coverage by 1%. The diff coverage is 75%.

@@         Coverage Diff         @@
##           main   #313   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        77     78    +1     
  Lines      2195   2206   +11     
  Branches    308    309    +1     
===================================
+ Hits       1876   1884    +8     
- Misses      231    233    +2     
- Partials     88     89    +1     
Flag Coverage Δ
unittests 85% <75%> (-1%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ImageSharp.Web/Processors/GrayscaleWebProcessor.cs 70% <70%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100% <100%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JimBobSquarePants commented 1 year ago

Thanks, but I don't want to add this.

If we add everything people ask for then we vastly increase the attack surface for DDOS. The library is extensible and they have all the tools to add their own processors.