JimBobSquarePants
commented
11 months ago @MichalStrehovsky I finally bit the bullet and installed the .NET 8 RC so I could use Sizoscope. With these changes and a tweak to the calling code from the sample project in #2486 we achieve much better results.
/// <summary>
/// Saves the given buffer using the filename extension as format.
/// </summary>
/// <param name="filename">The full pathname for the filename being written</param>
/// <param name="buffer">The image data stored as RGB buffer.</param>
/// <param name="width">The image width in pixels.</param>
/// <param name="height">The image height in pixels.</param>
public static void SaveImage(string filename, ReadOnlySpan<byte> buffer, int width, int height)
{
// Pass custom Configuration to avoid loading all default formats.
using var image = Image.LoadPixelData<Rgb24>(new(), buffer, width, height);
using var stream = new FileStream(filename, FileMode.Create);
var pngEncoder = new PngEncoder()
{
ColorType = PngColorType.Rgb
};
image.SaveAsPng(stream, pngEncoder);
}We could probably drop the size by another 40-45kb if we refactored the way the quantizer is loaded in the png encoder, for some reason the compiler cannot trim out the construction of that type but that's beyond the scope of this PR.
MichalStrehovsky
Prerequisites
Description
Fixes #2486
As discussed in the linked issue
AdvancedImageExtensions.GetConfiguration()causes the AOT compiler to include all image unused formats due to the null check and assignment ofConfiguration.Default.Since that null check is unavoidable without an API change, I decided to make it by making
IConfigurationProviderpublic and exposing the property directly.While developers should be careful to not edit the configuration singleton, I do not consider accessing the configuration an advanced scenario since we already provide means to construct and pass custom configuration to our types.