[x] I have written a descriptive pull-request title
[x] I have verified that there are no overlapping pull-requests open
[x] I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules :cop:.
[x] I have provided test coverage for my change (where applicable)
Description
This fixes #2608 which incorrectly handles the a negative drawing target/background location when drawing an image, ensuing the correct portion of the foreground image is retained and never cropped incorrectly.
The foreground rectangle is supposed to be in the foreground images coordinate space where are the background location is in the background images coordinate space, so we need to offset the x, y by the amount we shrink it by when unifying them to determine the portion of the foreground we are interested in.
This still does not change the rules for the foregrounds rectangle as that should not support a negative x,y but only effects the background/target location we will draw the final cropped foreground image to.
Prerequisites
Description
This fixes #2608 which incorrectly handles the a negative drawing target/background location when drawing an image, ensuing the correct portion of the foreground image is retained and never cropped incorrectly.
The foreground rectangle is supposed to be in the foreground images coordinate space where are the background location is in the background images coordinate space, so we need to offset the x, y by the amount we shrink it by when unifying them to determine the portion of the foreground we are interested in.
This still does not change the rules for the foregrounds rectangle as that should not support a negative x,y but only effects the background/target location we will draw the final cropped foreground image to.