SixLabors / ImageSharp

:camera: A modern, cross-platform, 2D Graphics library for .NET
https://sixlabors.com/products/imagesharp/
Other
7.26k stars 844 forks source link

Fix animated png handling (issue #2708) #2710

Closed SpaceCheetah closed 3 months ago

SpaceCheetah commented 3 months ago

Prerequisites

Description

Identified and fixed the issues mentioned in issue #2708. Fix: ProcessInterlacedPaletteScanline now respects frameControl.XOffset Fix: PngDecoderCore handling of PngDisposalMethod.RestoreToBackground and RestoreToPrevious, for specification compliance. Metadata change: Added DefaultImageAnimated to PngMetadata. The apng format allows for the first frame to not be part of the animation sequence, which needs to be visible to users. Fix: Decoding and encoding when the default image is not animated

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

JimBobSquarePants commented 3 months ago

Note. We'll want to backport this to target the release/v3.1.x branch also.

SpaceCheetah commented 3 months ago

This can be backported to release/3.1.x with a simple cherry-pick. I can make a PR for that if you want.

JimBobSquarePants commented 3 months ago

This can be backported to release/3.1.x with a simple cherry-pick. I can make a PR for that if you want.

That would be amazing if you can!