Replace PngCrcChunkHandling - Githubissues

SixLabors / ImageSharp

:camera: A modern, cross-platform, 2D Graphics library for .NET

https://sixlabors.com/products/imagesharp/

Other

7.34k stars 847 forks source link

Replace PngCrcChunkHandling #2786

Closed JimBobSquarePants closed 1 month ago

JimBobSquarePants commented 1 month ago

Prerequisites

[x] I have written a descriptive pull-request title
[x] I have verified that there are no overlapping pull-requests open
[x] I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules :cop:.
[x] I have provided test coverage for my change (where applicable)

Description

This is a rework of #2589 for V4 that generalizes the segment error handling allowing us to specify rules during identification.

Removes PngCrcChunkHandling from PngDecoderOptions
Adds SegmentIntegrityHandling to DecoderOptions

PNG is currently the only format that uses these properties, but others can be migrated when required.

Erik-White commented 1 month ago

Excellent, this will be very useful!