SixLabors / ImageSharp

:camera: A modern, cross-platform, 2D Graphics library for .NET
https://sixlabors.com/products/imagesharp/
Other
7.48k stars 851 forks source link

Feature Request: handle Subject* metadata in Resize/Crop/Rotate transforms #463

Open vpenades opened 6 years ago

vpenades commented 6 years ago

Prerequisites

Description

Right now, when performing transformations that involve changing the pixel dimensions of the image, the Pixel Size metadata is automatically changed to match the new dimensions.

But there's some more metadata tags that hold pixel positional information these are:

My guess is that these tags are designed to mark the "main subject" within an image, if it's an image taken with a camera, it's probably the point or area used by the camera to focus.

So, if the value is properly set, it can be used for speed up operations like finding a face within an image (assuming the face is the main subject)

But if manually set, it can also be used for other purposes, like to define the "center/offset" of the image, or even the circle/rectangle of the "main element" within the image. In my case, I would like to use this tag to define the "Pivot" of a sprite in videogame asset authoring. Having a "pivot" in the image can be useful in many ways, and mybe, at some point in the future, GraphicsOptions could have an Enum to define the reference coordiante system as "TopLeft" or "SubjectPivot" or something like that.

I have a helper class to simplify access to these tags here.

My request is that, when performing operations such as Resize, Crop, Rotate, etc, the Subject* tags are adjusted accordingly, so the area represented by the Subject stays meaningful.

I agree some transforms might be diffucult or impossible to perform, so as fallback solutions I propose:

I agree that this is a group of metadata tags that are rarely used (I had a hard time finding official examples, found this, which, btw, has the subject area outside the image due to an image resize) , so maybe an intermediate solution would be to have some sort of callback.

JimBobSquarePants commented 3 months ago

@vpenades It's been a few years....

Is this something you're still interested in?

vpenades commented 3 months ago

hi, sorry for late reply, busy as usual...

I haven't touched the topic in a few years, but the issue is fairly straightforward to understand: there's some metadata in images that references the current image in its current dimension, for example the ROI metadata. If the image is manipulated in some way, like resized or cropped, the ROI stored in the metadata is no longer valid.

The only way I could think to fix this is that the metadata contains some kind of interface or listener that is called whenever the image is transformed in some way.

It's the kind of stuff that's easy to say but extremely difficult to do, specially taking into account the heterogeneous nature of metadata.

So I would tag this feature request as a "nice to have, but not worth the development time".

On the other side, I would try to improve the edition and manipulation of metadata as much as possible, because I think it's an underexploited feature of images.